feat(clerk-js): OrgProfile billing page and new subscription methods#5423
Merged
feat(clerk-js): OrgProfile billing page and new subscription methods#5423
OrgProfile billing page and new subscription methods#5423Conversation
🦋 Changeset detectedLatest commit: 3fbf27d The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OrgProfile billing page and new subscription methodsOrgProfile billing page and new subscription methods
Contributor
alexcarpenter
left a comment
There was a problem hiding this comment.
It looks like maybe the pricing table and checkout components are re-rendering multiple times causing the table to flicker on load, then opening checkout opens drawer/closes then reopens.
Screen.Recording.2025-03-24.at.11.31.01.AM.mov
Contributor
alexcarpenter
left a comment
There was a problem hiding this comment.
Looking good so far, do you think there will be redirect urls for both checkout complete and subscription cancel callbacks?
packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationBillingPage.tsx
Outdated
Show resolved
Hide resolved
alexcarpenter
approved these changes
Mar 25, 2025
brkalow
approved these changes
Mar 26, 2025
packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationBillingPage.tsx
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/PricingTable/SubscriptionDetailDrawer.tsx
Outdated
Show resolved
Hide resolved
jacekradko
reviewed
Mar 26, 2025
jacekradko
reviewed
Mar 26, 2025
jacekradko
reviewed
Mar 26, 2025
alexcarpenter
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds billing page (and
PricingTable) to theOrgProfilealong with the newusePlanshook.Also adds two subscription methods to get active subscriptions for the current user and the current org.
Renames the
PlanDetailDrawer->SubscriptionDetailDrawer.Resolves COM-184 COM-146
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change